Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appraisal gemset for Capybara 2 and 3 #241

Open
mattheworiordan opened this issue Oct 21, 2018 · 5 comments
Open

Add Appraisal gemset for Capybara 2 and 3 #241

mattheworiordan opened this issue Oct 21, 2018 · 5 comments

Comments

@mattheworiordan
Copy link
Owner

See #236 (review) for backgruond.

@eiapopeia
Copy link

I also see the warning:
capybara-screenshot could not detect a screenshot driver for 'apparition'. Saving with default with unknown results.
The screenshot itself looks really well, thought.

Gems:

  • apparition (0.2.0)
  • capybara (3.20.2)
  • capybara-screenshot (1.0.22)

@sedubois
Copy link
Contributor

I also got that warning when using apparition. Similar to the solution in #22, I've added this to my rails_helper.rb and it seems to work: Capybara::Screenshot.register_driver(:apparition, &:save_screenshot).

@eiapopeia
Copy link

Thanks for the hint. This fixes the message for me.

I think it should be already built in because apparition driver will be the default in the future.

@mattheworiordan
Copy link
Owner Author

@eiapopeia @sedubois sorry for the slow reply on this. I agree apparition is likely to win the battle here. Would either of you be willing to do a PR with my help?

@mattheworiordan
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants