Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js extension not added to lib/*.js #209

Open
atoy40 opened this issue Sep 23, 2020 · 1 comment
Open

js extension not added to lib/*.js #209

atoy40 opened this issue Sep 23, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@atoy40
Copy link

atoy40 commented Sep 23, 2020

The current version does not have the .js added to import statments in lib/*.js compiled files
this is because the TS compiler return an error :

node_modules/.bin/tsc
src/use-context.ts:60:18 - error TS2774: This condition will always return true since the function is always defined. Did you mean to call it instead?

60     this.value = unsubscribe ? value : Context.defaultValue;
                    ~~~~~~~~~~~


Found 1 error.

So the next command in the makefile (sed) is not called. I've fixed this error and then sed has been call successfully.

Anthony.

@matthewp
Copy link
Owner

matthewp commented Oct 9, 2020

Can you send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants