bug report in interpretability_module.py

[ForeverYoung666]

in interpretability_module.py line 98:
max_depth = int(np.ceil(np.log2(iforest.max_samples)))
there is a bug here: if you train iforest model with parameters: max_samples = 1.0，iforest.max_samples will be 1.0 and the "max_depth" here will be 0. actually you want iforest.max_samples to be the number of training samples

[rcrupi]

Could the solution be substitute "iforest.max_samples" with "iforest.max_samples_"?

[ForeverYoung666]

yes, I think so, after referring to the doc of sklearn 发自我的iPhone

…

------------------ Original ------------------ From: rcrupi ***@***.***> Date: Mon,Apr 3,2023 5:36 PM To: mattiacarletti/DIFFI ***@***.***> Cc: ForeverYoung666 ***@***.***>, Author ***@***.***> Subject: Re: [mattiacarletti/DIFFI] bug report in interpretability_module.py(Issue #2) Could the solution be substitute "iforest.max_samples" with "iforest.max_samples_"? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>