When built using pip in editable mode the package does not compile

[mpacer]

So I just tried pip install -e . to get an editable version of the package from within the cloned repo and got back the following error:

Complete output from command python setup.py egg_info:
running egg_info
creating pybasicbayes.egg-info
writing dependency_links to pybasicbayes.egg-info/dependency_links.txt
writing requirements to pybasicbayes.egg-info/requires.txt
writing top-level names to pybasicbayes.egg-info/top_level.txt
writing pybasicbayes.egg-info/PKG-INFO
writing manifest file 'pybasicbayes.egg-info/SOURCES.txt'
warning: manifest_maker: standard file '-c' not found

error: package directory 'pybasicbayes/internals' does not exist

----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in …/Projects/pybasicbayes

I'm guessing you recently changed the structure of the module, as there seems to be no internals submodule at all. Is this now the distributions submodule?

If so I think all you would need to change is

      packages=['pybasicbayes',
              'pybasicbayes.internals',
              'pybasicbayes.util',
              'pybasicbayes.testing'],

to

  packages=['pybasicbayes',
              'pybasicbayes.distributions',
              'pybasicbayes.util',
              'pybasicbayes.testing'],

I'll make a PR once I get this to successfully build. The modification I made to this effect seems to allow it to successfully pip install…, but for some reason now the inplace build doesn't work, saying that it doesn't know what install_requires means, but I'm still using the python setup.py build_ext --inplace from the top level of the directory. So I'm a little baffled.

Edit: Ok so it installs just fine with pip, it's just if I try to use python setup.py it uses distutils, which doesn't have install_requires though setuptools which is activated when using pip. Ugh python package management makes my head hurt. PR on its way.

[mattjj]

Makes my head hurt too 👎

Does merging #23 mean this should be closed, or is there more to be done?