Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should pyslds list pypolyagamma in install_requires? #7

Open
mattjj opened this issue Dec 2, 2016 · 1 comment
Open

should pyslds list pypolyagamma in install_requires? #7

mattjj opened this issue Dec 2, 2016 · 1 comment
Assignees

Comments

@mattjj
Copy link
Owner

mattjj commented Dec 2, 2016

Should we make pypolyagamma optional, instead of listing it in the install_requires argument to setup in setup.py? It might make the build/install process simpler, though users who want to do count modeling would need to install it separately (with pip install pypolyagamma). We could expand the installation instructions in the README to have these alternatives:

To install pyslds with pypolyagamma for fast inference in count data models, run

git clone https://github.com/mattjj/pyslds.git
pip install pypolyagamma -e pyslds

See the pypolyagamma build instructions to consider installing it with OpenMP support.

To install pyslds without pypolyagamma (which you can install separately later), just run

git clone https://github.com/mattjj/pyslds.git
pip install -e pyslds
@slinderman
Copy link
Collaborator

I made pypolyagamma optional in 99677ee. I followed the same design pattern that we used in pylds, namely, using *CountSLDS to cordon off the Pólya-gamma code.

The README still needs to be updated to include this detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants