Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmet peer dependency #4

Closed
dustinfarris opened this issue Sep 14, 2016 · 3 comments
Closed

Unmet peer dependency #4

dustinfarris opened this issue Sep 14, 2016 · 3 comments

Comments

@dustinfarris
Copy link

I want to hijack some of the code here for a non-webpack Ember/Cashay integration I'm working on. package.json specifies webpack as a peer dependency which I would rather not be required for what I'm doing.

@dustinfarris
Copy link
Author

@mattkrick what are your thoughts on using this as repo as a toolbelt for non-webpack integrations? Is that changing the scope here inappropriately? Would it be better form for me to create a similar Ember-specific "loader" repo (essentially copy+pasting everything here, but with Ember scaffolding)?

@mattkrick
Copy link
Owner

Oh yeah, i would definitely avoid any work on this repo, it's just a bunch of dead code. I originally planned to break out the webpack loader as a separate npm package, but realized it was so much cleaner just doing it inside cashay, plus if you use tree-shaking accordingly, it won't increase the client payload. The code inside cashay/schema is more up to date.

@dustinfarris
Copy link
Author

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants