Refactor PendingMigrationCheck #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor PendingMigrationCheck so that #last_deployed_commit is an input instead of lookup. This simplifies PendingMigrationCheck and allows users of the configuration option `migration_check` to have a simpler interface to implement.
|
This was included in PR #81 so you can close if you prefer |
|
just pinging to see if we can get some movement on this. Thanks. |
|
Thanks @apsoto for the ping. I'll check back in with this when I have some open source time. Probably Friday. Thanks again for your work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor PendingMigrationCheck so that #last_deployed_commit is an input
instead of lookup. This simplifies PendingMigrationCheck and allows
users of the configuration option
migration_checkto have a simplerinterface to implement.