-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernise the way proxy connections work #88
Comments
The strategy here will be to add a middleware to the guzzle stack, which configures the proxy settings for the request, based on the URL of the request, as in the above function. The main function is currently protected, and the best strategy here will likely be to copy the Awsclient implementation to a new function that accepts a GuzzleClient, and from there, configures the middleware into the callstack in the same way. The same middleware function should work but might need some tweaking |
* Also fixes unit tests to be consistent if test server sets proxy in config.php.
* Also fixes unit tests to be consistent if test server sets proxy in config.php.
* Also fixes unit tests to be consistent if test server sets proxy in config.php.
* Also fixes unit tests to be consistent if test server sets proxy in config.php.
* Also fixes unit tests to be consistent if test server sets proxy in config.php.
…cal_aws_proxy_builders Issue #88 Use local_aws middleware to manage requests with proxies
* Also fixes unit tests to be consistent if test server sets proxy in config.php.
This will redo the work done in this issue:
#9
and do it so that all the proxy logic is handled centrally in local_aws instead
https://github.com/catalyst/moodle-local_aws/blob/master/classes/local/client_factory.php#L44-L60
The text was updated successfully, but these errors were encountered: