Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.dirname is deprecated. #76

Open
Yanchek99 opened this issue Jan 18, 2017 · 6 comments
Open

Object.dirname is deprecated. #76

Yanchek99 opened this issue Jan 18, 2017 · 6 comments

Comments

@Yanchek99
Copy link

Argument to path.dirname must be a string

Object.dirname (/Applications/Development/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:9:10)
Object.showClientName (~/.atom/packages/atom-perforce/lib/atom-perforce.js:555:24)
<unknown> (~/.atom/packages/atom-perforce/main.js:141:22)
Function.module.exports.Emitter.simpleDispatch (/Applications/Development/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
Emitter.emit (/Applications/Development/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
<unknown> (/Applications/Development/Atom.app/Contents/Resources/app.asar/src/pane-container.js:348:27)
@bquack
Copy link

bquack commented Jan 20, 2017

Experiencing the same error on Atom version 1.13.0. Windows 10

@ghost
Copy link

ghost commented Jul 5, 2017

Experiencing the same error on Atom version 1.18.0. Windows 7

@coolgeng
Copy link

Experiencing the same error on Atom version 1.20.1. Mac Sierra

@Lebios
Copy link

Lebios commented Nov 1, 2017

Experiencing the same error on Atom version 1.21.2. win7

@hoover900
Copy link

I think I have a fix for this. @konchunas fix looks to be right, but it seems to be missing "()" at the end of editor.getpath. Am I wrong in thinking that editor.getpath is not going return anything since it's not a string nor a function?

@saperio
Copy link
Contributor

saperio commented Dec 21, 2019

Add pr for this: #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants