Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add autocomplete="off" #107

Open
IliyanTatarov opened this issue Feb 21, 2021 · 5 comments
Open

Please add autocomplete="off" #107

IliyanTatarov opened this issue Feb 21, 2021 · 5 comments
Labels
question Further information is requested

Comments

@IliyanTatarov
Copy link

IliyanTatarov commented Feb 21, 2021

Please add autocomplete="off" to the search input. Maybe its good idea to to change the input type to "search" as well.

@mattzollinhofer
Copy link
Owner

I'm not sure about this. We currently use aria-autocomplete to tell screen-reader users about the expected behavior for this component, but I'm not sure how aria-autocomplete interacts with simple autocomplete.

I feel similarly to your type=search suggestions. I'm not opposed to it, but I'm unsure about how it interacts with role=searchbox.

This very well may be obvious to everyone besides me, but could you provide some more details on the problem you're trying to solve/the use case for making this change? A major priority of this project is to be as accessible as possible, so any thoughts you have on these changes and how they relate to the attributes I mentioned would be appreciated.

@mattzollinhofer mattzollinhofer added the question Further information is requested label Apr 6, 2021
@MaBre01
Copy link

MaBre01 commented Jun 24, 2021

Hi!
I had a similar problem.

The problem result from the browser which display suggestions on the suggestions container of the vue-typeahead-bootstrap component (but it does not appear on all my components).

I fixed it with adding autocomplete="off" props on the input with VueJS refs in the mounted function.

@darrinmn9
Copy link
Contributor

I am also experiencing this problem. Browser based autocomplete suggestions are being shown on top of the suggestions items list provided by this component, leading to ugly UI and many times being unable to see the options suggested by this component (because chrome/browser is completely overlapping it).

@darrinmn9
Copy link
Contributor

A major priority of this project is to be as accessible as possible, so any thoughts you have on these changes and how they relate to the attributes I mentioned would be appreciated.

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete

I can do some research on this, but I don't believe autocomplete="off" negatively affects a11y. The feature is more about the allowing the user's browser to suggest hints (in a dropdown) of what the user could be trying to type (based on w/e logic the browser chooses). Here is a very strict, WAI-ARIA compliant library that suggests that option as well. https://bootstrap-vue.org/docs/components/form-input#datalist-support

@mattzollinhofer
Copy link
Owner

Yep, thanks for looking into the accessible side a bit, this sounds good, let's set it to "off"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants