Skip to content

Commit 876ee1a

Browse files
committed
refactor: no implicit override in TypeScript code
Easily detect when super methods are removed.
1 parent 07d8220 commit 876ee1a

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

projects/_shared/src/custom-shapes.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class CustomRectangleShape extends RectangleShape {
1313
this.isRounded = true; // force rounded shape
1414
}
1515

16-
paintBackground(
16+
override paintBackground(
1717
c: AbstractCanvas2D,
1818
x: number,
1919
y: number,
@@ -24,7 +24,7 @@ class CustomRectangleShape extends RectangleShape {
2424
super.paintBackground(c, x, y, w, h);
2525
}
2626

27-
paintVertexShape(
27+
override paintVertexShape(
2828
c: AbstractCanvas2D,
2929
x: number,
3030
y: number,
@@ -41,7 +41,7 @@ class CustomEllipseShape extends EllipseShape {
4141
super(bounds, fill, stroke, 5);
4242
}
4343

44-
paintVertexShape(
44+
override paintVertexShape(
4545
c: AbstractCanvas2D,
4646
x: number,
4747
y: number,

projects/_shared/src/generate-graph.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ class CustomGraph extends BaseGraph {
3030
// Register builtin styles
3131
PerimeterRegistry.add('ellipsePerimeter', Perimeter.EllipsePerimeter);
3232
PerimeterRegistry.add('rectanglePerimeter', Perimeter.RectanglePerimeter); // declared in the default vertex style, so must be registered to be used
33+
3334
EdgeStyleRegistry.add('orthogonalEdgeStyle', EdgeStyle.OrthConnector, {handlerKind: 'segment', isOrthogonal: true});
3435

3536
const arrowFunction = EdgeMarker.createArrow(2);

projects/_shared/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
"declaration": true,
1616
"noUnusedLocals": true,
1717
"noUnusedParameters": true,
18-
"noImplicitReturns": true
18+
"noImplicitReturns": true,
19+
"noImplicitOverride": true,
1920
},
2021
"include": ["src"]
2122
}

0 commit comments

Comments
 (0)