Skip to content

Commit

Permalink
chore: Tweak lint rules
Browse files Browse the repository at this point in the history
  • Loading branch information
maxmilton committed Sep 3, 2023
1 parent f3766d6 commit 685a183
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@ module.exports = {
// byte savings
'@typescript-eslint/no-confusing-void-expression': OFF,
// worse performance
'@typescript-eslint/prefer-string-starts-ends-with': OFF,
'@typescript-eslint/prefer-includes': OFF,
// worse performance
'@typescript-eslint/prefer-for-of': OFF,
// worse performance
'@typescript-eslint/prefer-string-starts-ends-with': OFF,
// void return can be used for efficient code (if used safely!)
'consistent-return': WARN,
// useful for compact and memory efficient code... but be careful!
Expand Down
3 changes: 3 additions & 0 deletions test/unit/macro.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ import { compile as compileNoMacro } from '../../src/runtime/macro';

// TODO: Consider using inline snapshots once bun:test supports them.

// TODO: Test not text ref when text includes whitespace
// TODO: Test not text ref when text has escapsed @ character (e.g. \@)

describe('compile', () => {
// FIXME: Test for each of the compile macro options; keepComments, keepSpace
// ↳ When keepComments, check refs metadata calculations are still correct.
Expand Down

0 comments on commit 685a183

Please sign in to comment.