Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinFraudClientInterface? #165

Open
willy-opale opened this issue Mar 13, 2024 · 0 comments
Open

MinFraudClientInterface? #165

willy-opale opened this issue Mar 13, 2024 · 0 comments

Comments

@willy-opale
Copy link

The current MinFraud implementation is very hard to test (in our test suites with PHPUnit). We are forced to create a class that inherits from MaxMind\MinFraud but disables the constructor.

It would be very helpful if some MinFraudClientInterface could be created thus making MaxMind\MinFraud implement it. We could then use this in our tests to easily create a mock object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant