dropdown initial look #9
Conversation
|
Can you please resolve the conflicts and also update your branch to the latest which has Kubera Portal and Kuber Core themes too. Also, update your stories accordingly. |
Signed-off-by: armen5 <[email protected]>
armen5
force-pushed
the
dropdown-component
branch
from
758ef6e
to
dfcb583
Compare
Signed-off-by: armen5 <[email protected]>
Signed-off-by: armen5 <[email protected]>
src/core/Dropdown/Dropdown.tsx
Outdated
| const showDropdown = Boolean(anchorElement) ? classes.show : classes.hide; | ||
| return ( | ||
| <div className={classes.root} data-id="dropdownElement"> | ||
| <ButtonFilled |
There was a problem hiding this comment.
button to open the menu shouldn't be part of the component...because we have the component in header and all where there is no button
Signed-off-by: armen5 <[email protected]>
Signed-off-by: armen5 <[email protected]>
…ropdown-component
Signed-off-by: armen5 <[email protected]>
|
|
|
@S-ayanide @arkajyotiMukherjee @AVRahul I removed button from component as suggested Arko in his last comment, but in that case I have to add it into stories to pass anchorEl value to component to show dropdown in the right place,where the click was made,but for that I needed usestate in stories but couldn't made it work correctly,if I'm in wrong way please give me suggestion or maybe this is ok as if we use this component in page where we use useState, we will be able pass anchorEl and I think it will work correctly,but for now I wasn't able to show it in storybook,the screens are new but code doesn't include button |
|
useState is possible in stories...check RadioButton component @armen5 |
Signed-off-by: armen5 <[email protected]>
This is the initial look for Dropdown,here are photos, just colors I think aren't good, but I pick them as given in figma.