Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong implementation parseFrom method? #34

Open
alex-aparin opened this issue Aug 17, 2018 · 0 comments
Open

Wrong implementation parseFrom method? #34

alex-aparin opened this issue Aug 17, 2018 · 0 comments

Comments

@alex-aparin
Copy link

I looked at implementation of parseFrom method, here is piece of code:

for (offs = 0; offs < len - 1; offs++)
if (buf[offs] == 0xFF && buf[offs + 1] == 0xE1) break;

As I understand, it searches exif marker. Is it correct? AS I understand, we should skip internal data of markers, and here we should find length of marker segment, if it is not exif then we should skip it (otherwise we can accidentially find that marker data from different marker segment). Am I right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant