Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation via data annotations does not support dependency injection / resolution #157

Open
reddogaw opened this issue Sep 2, 2024 · 0 comments · May be fixed by #158
Open

Validation via data annotations does not support dependency injection / resolution #157

reddogaw opened this issue Sep 2, 2024 · 0 comments · May be fixed by #158

Comments

@reddogaw
Copy link

reddogaw commented Sep 2, 2024

In a custom data annotation, the ValidationContext typically supports acting as an IServiceProvider to resolve dependencies required for the validation action.

This support is typically provided by the ValidationContext constructor overload which allows you to pass the IServiceProvider used by the application. However, that's currently not being passed by Cocona, so it's leading to unregistered dependency exceptions when resolving within a custom validation attribute's IsValid method.

Example which is silly but indicative:

    class IsEvenUsingDependencyInjectionAttribute : ValidationAttribute
    {
        protected override ValidationResult? IsValid(object? value, ValidationContext validationContext)
        {
            if (value is not int number)
            {
                return new ValidationResult($"Could not validate value, values's type is {value?.GetType()}");
            }
            
            var calculator = validationContext.GetRequiredService<Calculator>();
            return calculator.IsEven(number)
                ? ValidationResult.Success
                : new ValidationResult("Value is an uneven number.");
        }
    }
    
    class Calculator
    {
        public bool IsEven(int number) => number % 2 == 0;
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant