docker: Build and push to dockerhub #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
where would we get a username and password from ? From docker hub ? |
|
Yeah the user/pass would be for a Docker Hub account. This PR is setup to login to Hub as that appears to be where these images were previously built. I'd recommend creating a new account on Docker Hub as |
philipcristiano
force-pushed
the
docker-build-push
branch
2 times, most recently
from
38e2bca
to
7493483
Compare
philipcristiano
force-pushed
the
docker-build-push
branch
from
7493483
to
41e3cd8
Compare
|
Updated to also build linux/arm64 image into a multi-platform image. Tested in my user-fork with image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would need a
DOCKER_USERNAMEandDOCKER_PASSWORDset as Github Actions Secrets.Closes #18