Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing guide? #39

Open
lalo2302 opened this issue Jan 8, 2018 · 6 comments
Open

Contributing guide? #39

lalo2302 opened this issue Jan 8, 2018 · 6 comments

Comments

@lalo2302
Copy link

lalo2302 commented Jan 8, 2018

Hi!

I want to contribute to the development, but I see no guide, rules or whatever. Maybe a roadmap? A trello/asana board?

I can help in this things but I don't really know who is in charge of publishing or merging to master.

@blesson3
Copy link

blesson3 commented Jan 9, 2018

I'd also like to contribute to development, but am unsure of what needs to be done. I think a Trello board would be optimal for tracking features/bugs/etc...

@niko-dunixi
Copy link

Plus one to this. I'd honestly like to help with this too.

@lalo2302
Copy link
Author

We could all do it right here on Github, via the issues manager. We can set the enhancement label for features to add, and then do the pull requests.

Right now I see 2 things that can be done:

  1. Comment the code
  2. Add workouts to the Health App

Would be great if @mazurio gives an opinion about it 😄

@bamse16
Copy link
Contributor

bamse16 commented Jan 13, 2018

It would be great if he could show up to share his plan with us, but I've read that @mazurio is busy with life stuff until June/July. You can search r/bodyweightfitness for his latest posts.

I've started adding the workouts to the Health App on this branch https://github.com/bamse16/bodyweight-fitness-ios/tree/feature/healthkit, however I can't test it without a paid developer account. HealthKit requires a special entitlement, that does not work with the free developer account.

Re what's left to do, there are a couple of bugfixes, in GitHub, and a couple of good suggestions on reddit. Also, there's a bit of refactoring needed. I wouldn't add comments to the code though. It's pretty easy to get it, once you've spent a bit of time.

@lalo2302
Copy link
Author

lalo2302 commented Jan 15, 2018

Thanks @bamse16! Already read his posts at reddit. So I'll start working on bugfixes to start getting comfortable with the app. I only have 1 question:

If I use the app from the appstore, but at the same time I build and run the app of development on my device, is the app from the appstore gonna be replaced, erasing all my info?

EDIT: I think I can't run the app at all without a paid developer account :( Thought it was only the HealthKit, but it is needed for In-App purchases. Too bad. Any way, I may buy one in a few months.

@bamse16
Copy link
Contributor

bamse16 commented Jan 15, 2018

To get it installed as a different app, make sure that you change the bundle identifier.

Regarding installing it on your phone, for HealthKit, you need an active paid account to do that. Hopefully, @mazurio can add us to his account, so we can distribute TestFlight builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants