Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Providers use Result (Vcs_base refactor) #34

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Providers use Result (Vcs_base refactor) #34

merged 11 commits into from
Oct 22, 2024

Conversation

mbarbin
Copy link
Owner

@mbarbin mbarbin commented Oct 22, 2024

This PR implements Vcs_base stage 4 refactor as per TODO.md - Trait implementation use Result.

Changed

  • Provider interfaces now uses Vcs.Result type instead of Or_error.

Fixed

  • Changed some exceptions raised by the vcs related libraries to the Vcs.E exception.

Removed

  • Removed Vcs.Exn.raise_s since it is causing bisect_ppx unvisitable points.

@mbarbin mbarbin merged commit 1df0b7a into main Oct 22, 2024
5 checks passed
@mbarbin mbarbin deleted the providers-result branch October 22, 2024 13:32
@mbarbin mbarbin mentioned this pull request Oct 22, 2024
Closed
11 tasks
@mbarbin mbarbin added this to the Remove base dependencies milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Remove base dependencies
Development

Successfully merging this pull request may close these issues.
1 participant
@mbarbin