From 6e0d762efbfd60979e6596ad7e19735cb8efeb9f Mon Sep 17 00:00:00 2001 From: Nikolaos Kakouros Date: Sat, 28 Sep 2019 23:29:54 +0200 Subject: [PATCH 1/2] Replace help tokens without --help-filter --- libexec/help | 14 +++++++++++--- tests/help.bats | 30 ++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 3 deletions(-) diff --git a/libexec/help b/libexec/help index 7c3d207..c432cf8 100755 --- a/libexec/help +++ b/libexec/help @@ -116,14 +116,22 @@ _@go.help_message_for_command() { local filter_pattern='# [Hh]elp [Ff]ilter['$'\n\r'']' - if [[ "$(< "$__go_cmd_path")" =~ $filter_pattern ]]; then + if [[ "$(<"$__go_cmd_path")" =~ $filter_pattern ]]; then __go_cmd_desc="$(_@go.run_command_script "$__go_cmd_path" --help-filter \ "$__go_cmd_desc")" fi + if [[ "$(declare -p _GO_HELP_TOKENS 2>/dev/null || :)" =~ declare\ -A ]]; then + for token in "${!_GO_HELP_TOKENS[@]}"; do + __go_cmd_desc="${__go_cmd_desc//{{$token\}\}/${_GO_HELP_TOKENS[$token]}}" + done + fi + if [[ -d "${__go_cmd_path}.d" ]]; then - __go_cmd_desc+="$(printf '\nSubcommands:\n\n'; \ - _@go.source_builtin 'commands' --summaries "${__go_cmd_path}.d")" + __go_cmd_desc+="$( + printf '\nSubcommands:\n\n' + _@go.source_builtin 'commands' --summaries "${__go_cmd_path}.d" + )" fi @go.printf "$_GO_CMD $cmd_name - $__go_cmd_desc\n" } diff --git a/tests/help.bats b/tests/help.bats index 3092022..97a5194 100644 --- a/tests/help.bats +++ b/tests/help.bats @@ -168,6 +168,36 @@ teardown() { assert_success "${expected[@]}" } +@test "$SUITE: replace help tokens using _GO_HELP_TOKENS" { + if [[ "${BASH_VERSINFO[0]}" -lt 4 ]]; then + skip + fi + + local cmd_script=( + '#' + '# Does foo stuff' + '#' + '# Usage: {{go}} {{cmd}} <{{FOO_VALID_ARGS}}>' + '' + 'declare -r FOO_VALID_ARGS=("bar" "baz" "quux")' + '' + ) + @go.create_test_command_script 'foo' "${cmd_script[@]}" + + @go.create_test_go_script \ + "declare -gA _GO_HELP_TOKENS=(['FOO_VALID_ARGS']='bar|baz|quux')" \ + '@go "$@"' + + + run "$TEST_GO_SCRIPT" help foo + + local expected=( + "$TEST_GO_SCRIPT foo - Does foo stuff" + '' + "Usage: $TEST_GO_SCRIPT foo ") + assert_success "${expected[@]}" +} + @test "$SUITE: add subcommand summaries" { local cmd_template=$'# Does {{CMD}} stuff\n' cmd_template+=$'#\n' From b34c9d4b5edbd8442ba895bb892dc897eb54cba9 Mon Sep 17 00:00:00 2001 From: Nikolaos Kakouros Date: Sat, 28 Sep 2019 23:36:50 +0200 Subject: [PATCH 2/2] Updates help help text --- libexec/help | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/libexec/help b/libexec/help index c432cf8..14a8832 100755 --- a/libexec/help +++ b/libexec/help @@ -53,6 +53,17 @@ # values, to keep the text in sync automatically. It's good practice to parse # tokens within `{{` and `}}` as is common with templating engines, but it's not # enforced. +# +# An alternative way to perform token replacement (for Bash version >= 4) is to +# use the _GO_HELP_TOKENS associative array. The index of an item is the token +# to be searched and replaced and the value of the item is the replacement +# value. For instance: +# +# declare -A _GO_HELP_TOKENS=([project_dir]=~/Projects/my-project) +# +# will replace 'project_dir' in the help text with '~/Projects/my-project'. By +# default, this array is empty and you will have to declare it and add tokens to +# it. _@go.usage() { local cmd_paths=("$_GO_SCRIPTS_DIR")