chore: remove Solari screen type and "v1" code #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaddox5
approved these changes
Nov 1, 2024
|
|
||
| def index(conn, _params) do | ||
| render_not_found(conn) | ||
| end | ||
|
|
||
| def show_image(conn, %{"filename" => filename}) do |
There was a problem hiding this comment.
Do we know what uses this endpoint? Curious if we can just get rid of this file altogether.
There was a problem hiding this comment.
It is definitely being used somehow in the wild, based on logs (search for GET /image/), so I'm inclined not to mess with it for now.
* Remove the `solari` screen type; we have no remaining screens of this type in the wild. * Remove the "v1" screen page/API endpoints; there are now no remaining v1 screen types. * Remove a substantial amount of code that was only used by v1 screens (likely not all of it, but there are few reliable tools available for detecting unused "public" code in Elixir). * Remove the `solari_large_v2` screen type; this was added a long time ago in anticipation of the "large" Solari layout being ported to the v2 framework, but no real functionality was ever added to it, and the only screens of this type in the wild are now permanently offline and waiting to be decommissioned.
digitalcora
force-pushed
the
cfg-remove-solari
branch
from
61f83aa
to
1479e1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
solariscreen type; we have no remaining screens of this type in the wild.Remove the "v1" screen page/API endpoints; there are now no remaining v1 screen types.
Remove a substantial amount of code that was only used by v1 screens (likely not all of it, but there are few reliable tools available for detecting unused "public" code in Elixir).
Remove the
solari_large_v2screen type; this was added a long time ago in anticipation of the "large" Solari layout being ported to the v2 framework, but no real functionality was ever added to it, and the only screens of this type in the wild are now permanently offline and waiting to be decommissioned.