Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Different Branches #25

Closed
ChristophLHR opened this issue May 10, 2023 · 4 comments
Closed

Check for Different Branches #25

ChristophLHR opened this issue May 10, 2023 · 4 comments
Assignees

Comments

@ChristophLHR
Copy link
Member

ChristophLHR commented May 10, 2023

Allow for the specific version of libraries to be requested.
These should be in their own Branch.
There must be a file provided by the libraries which specifies which version is found in which branch.

{
   [verionNo : string] : string
}

Example

{
 ["21"] = "Version_21",
 ["22"] = "TestFeature",
}
@ColdIV
Copy link
Member

ColdIV commented May 12, 2023

@ChristophLHR just for the sake of consistency, can we define the version format as [major].[minor].[patch]?
So always just numbers separated with dots:, e.g.: 1.6.3
This would make it easier to work with them in the future.

@ChristophLHR
Copy link
Member Author

@ColdIV as for now, I have had no intension to support it to such depth.
Currently the version will just be a string. Ether the version if found, or it isn't.

Therefore the user can handle the numbering however they choose.

@ChristophLHR ChristophLHR changed the title Check for Required version Check for Different Branchen May 12, 2023
@ChristophLHR ChristophLHR changed the title Check for Different Branchen Check for Different Branches May 12, 2023
@ColdIV
Copy link
Member

ColdIV commented May 12, 2023

After discussing this issue further, I think it is kind of similar to this one #2
Maybe you can combine those issues and implement it together.

@ChristophLHR
Copy link
Member Author

This issue will be closed, I will start working on issue #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants