Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QLC+ 5] Channel settings for fixtures shows each device type only once #1619

Open
DunklerPhoenix opened this issue Sep 29, 2024 · 5 comments

Comments

@DunklerPhoenix
Copy link

DunklerPhoenix commented Sep 29, 2024

Describe the bug
Fixtures of the same type can't be edited after they got added to the viewer. The edit window show always only one and I can only edit one of them (often the last)

To Reproduce
Steps to reproduce the behavior:

  1. Add two fixtures of the same type
  2. Move them in the Universe View a bit apart from each other
  3. Select one in the fixture groups
  4. Click edit button
  5. See only one of the fixtures

Expected behavior
Each added fixture should be visible here. Then I can set one fixture of e.g. the LED Strobe to 13 CH and the other to 54 CH.

Screenshots

Bildschirmfoto vom 2024-09-29 09-25-01
Bildschirmfoto vom 2024-09-29 09-25-15
Bildschirmfoto vom 2024-09-29 09-34-29

Desktop (please complete the following information):

  • OS: Linux (Ubuntu)
  • QLC+ Version: qlcplus-qt5qml-5.0.0_Beta_3-20240928-a76affd
@yestalgia
Copy link
Contributor

yestalgia commented Sep 29, 2024

Bug confirmed on Windows 11.

The "name" text wrapping also appears to be broken.

Thanks for your report.

image

@mcallegari
Copy link
Owner

This is somehow related to
https://www.qlcplus.org/forum/viewtopic.php?t=17237

The root cause is always not-unique names. In fact, if you leave the names QLC+ proposes when adding new fixtures (with # number) it should work correctly
I need to think a better way to handle duplicate names or force users to use unique names.

@DunklerPhoenix
Copy link
Author

DunklerPhoenix commented Sep 29, 2024

Theoretical you can do it like some operating systems (linux) and add automatically a # 1 and count upwards if # 1 is already in use.

The problem could be the check for duplicate named while renaming and stuff like that. It needs to be added in many places I think

Unfortunately I don't have the knowledge to help you out.

Or every object needs to get an unique id.

@yestalgia
Copy link
Contributor

yestalgia commented Sep 29, 2024

Only a suggestion, but this might be one of the reasons FixtureIDs are common in other lighting software. A unique FixtureID would allow a few things:

  • This issue to be resolved
  • Cross-Show Compatibility: Maintain consistent fixture references across shows for scripting.
  • "Unpatched" fixtures which can be programmed then patched later
  • Easier Documentation for lighting crews (fixture IDs on a stage plot tend to make more sense than names and DMX addresses)
  • It could possibly make RDM easier to implement when there are multiple of the same fixture.

@mcallegari
Copy link
Owner

Please check if this is fixed too with the latest build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants