Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Deploy.sh is Dangerous? #12

Open
tilkinsc opened this issue Sep 27, 2018 · 2 comments
Open

Current Deploy.sh is Dangerous? #12

tilkinsc opened this issue Sep 27, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@tilkinsc
Copy link
Contributor

A hardcoded /dev/sdb1 is pretty eww as well as sudoing. You should make people sudo deploy.sh. Also, perhaps a unique name for the mounting folder. Maybe even a temporary.

@mchlmmc
Copy link
Owner

mchlmmc commented Sep 28, 2018

Good change to make.
deploy.sh is just a simple utility for me to use, serving as a sort of template for other people that might want to develop. Now that CirnOS is gaining a bit of traction I should make a more generic and safe version.

Will do this sometime after my current demo and model 3 port.

@tilkinsc
Copy link
Contributor Author

I'll be waiting for that model 3 port :)

@mchlmmc mchlmmc added the bug Something isn't working label Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants