diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 3dd1959aa..be61ed883 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -67,12 +67,16 @@ repos: additional_dependencies: ["bandit[toml]"] - repo: https://github.com/pre-commit/mirrors-mypy - rev: v1.8.0 + rev: v1.9.0 hooks: - id: mypy files: ^vizro-core/src/ additional_dependencies: - - pydantic>=1.10.13, <2 # deliberately pinned to <2 until we bump our pydantic requirement to strictly >=2 + # Deliberately pinned to <2 until we bump our pydantic requirement to strictly >=2. + # pydantic>=1.10.15 includes this fix which flags some genuine type problems. These will take a while to fix + # or ignore so for now we just pin to 1.10.14 which doesn't flag the problems. + # https://github.com/pydantic/pydantic/pull/8765 + - pydantic==1.10.14 - repo: https://github.com/gitleaks/gitleaks rev: v8.18.2 @@ -121,3 +125,4 @@ ci: - bandit - mypy - gitleaks + - vale diff --git a/vizro-core/changelog.d/20240405_103212_antony.milne_fix_mypy.md b/vizro-core/changelog.d/20240405_103212_antony.milne_fix_mypy.md new file mode 100644 index 000000000..f1f65e73c --- /dev/null +++ b/vizro-core/changelog.d/20240405_103212_antony.milne_fix_mypy.md @@ -0,0 +1,48 @@ + + + + + + + + +