-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to create control headers with horizontal rulers #82
Comments
Card
to be a control type (e.g. to create control headers with horizontal rulers)
@maxchristlmck, first of all thanks for raising this draft PR and trying to solve above yourself - much appreciated! 🚀 The above behavior can be achieved without creating two new models as in your current draft PR but by leveraging the existing Card component. It wasn't clear, as CSS was missing for horizontal rulers on our side! In general you can create horizontal rulers with markdown as well, using either @maxchristlmck - would that potentially work for you? The only thing you would have to add as a user on top would be a custom CSS file where you overwrite some of the default properties of the Card. @antonymilne - The above change would require adding the Card component to the ControlType. What do you think? Both the Card and Button models seem to be quite useful as a ControlType so they can live on the left-side. |
Hi Li, your suggestion also works perfectly for me! Happy to go forward with this one :) |
Thank you for very much for the idea and drafting a PR @maxchristlmck! I completely understand why this would be useful but do have some qualms about adding Just to understand @maxchristlmck, could you see yourself wanting to put anything else in the control panel beyond just the title of the group and a horizontal line? e.g. writing a whole paragraph of text in markdown? |
Hey @maxchristlmck ! We had some internal technical discussions on what could solve the above issue in a clean and declarative way. In the end, we decided that the currently best route would be via a custom component as you already had it, but maybe a cleaner way of writing a custom component would be the example below. The To make it look nicer, you can add some custom CSS into a my_css.css
app.py
Thanks again for raising the issue and creating a PR! 🚀 Without it, we wouldn't have found CSS missing for horizontal rulers. Hopefully above helps :) I'll leave this issue open in case it's helpful for other users and if many people up-vote it, we might also add the ControlGroup or something similar as a component to our source code 👍 Hope that helped! |
We had another request for this. The above solution isn't working but should do so again after #903 is merged. |
What's the problem this feature will solve?
@maxchristlmck raised that he would like to have the ability to create grouping headers for the controls with a horizontal ruler in place, see this draft PR: #81
Describe the solution you'd like
Ability to add control headers and horizontal rulers
Alternative Solutions
Additional context
Code of Conduct
The text was updated successfully, but these errors were encountered: