-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to bump dmc #905
Comments
Yes, the |
This issue depends a bit on fixing the dash persistence bug. We can start working on this ticket, but the date_picker persistence will be harder to implement. |
Hi Vizro Team, I’m glad to hear that you’re considering upgrading to the latest version of Upgrading from version The current DMC version offers many benefits: enhanced stability, more features, and critical bug fixes, all thanks to its foundation on Mantine V7. You can find more details in our Roadmap. We’ve been making rapid progress on DMC, releasing updates approximately every two weeks. You can see recent release announcements in our GitHub Discussions. Benefits of Upgrading DMC in VizroAs Antony mentioned in this comment, version I understand the desire to minimize dependencies, but upgrading DMC has some advantages:
Draft Pull Request SummaryI’ve drafted a PR to upgrade Vizro to use DMC version
Next StepsI haven’t updated any tests yet, but I’ve verified functionality by running the example app in the hatch run examples:example dev The app works with all components and the theme switcher, and it’s ready for further testing. |
Can you say more about this bug? Is this a Vizro issue or can it be fixed in either Dash or DMC? I can't access the internal issue. |
Hi @AnnMarieW 👋 and thank you so much for your contribution! Let me clear the following question before we align about on the rest later today or sometime this week.
This issue in Vizro is an internal replication of the Dash issue outlined here: Dash Issue #2678. The bug relates to persistence behavior in Dash, and you can find a minimal reproducible example in the Plotly forum here. I’ll review your PR as soon as I can (likely later this week) and will update you on whether this Dash bug impacts the feasibility of bumping Vizro's dmc.DatePicker to 0.15. P.S. I’m actively working on addressing this bug on the Dash side. |
Hi @petar-qb I see that the DatePicker is not persistent in the Vizro app I ran in my PR, however, the |
Correct. That's a well known Vizro issue we also plan to address soon. |
Context: #901 (comment). dmc is now at 0.15. Let's consider unpinning:
After #895 I think the only dmc components we have left are
dmc.Switch
anddmc.DateRangePicker/dmc.DatePicker
.@huong-li-nguyen are there plans to replace
dmc.Switch
withdbc
?The text was updated successfully, but these errors were encountered: