Merge pull request #90 from diogo405/header-function

refactor: create a function to set default headers and avoid code duplication

Author: mskian

routes/dutch.js

@@ -3,18 +3,12 @@ const router = express.Router();
 import { pronounce } from "node-pronounce";
 import { readFileSync } from "fs";
 import { randomArrayItem } from "random-array-item";
+import { setDefaultHeaders } from "../utils/headers.js";
 var dutchRandomWord = [];
 const dutchWordsData  = JSON.parse(readFileSync(new URL("../data/dutch/words.json", import.meta.url)));
 
 router.get("/", function (req, res) {
-  res.header("Access-Control-Allow-Origin", "*");
-  res.header('Access-Control-Allow-Headers', 'Access-Control-Allow-Headers,Content-Type,Access-Control-Allow-Methods, Authorization, X-Requested-With');
-  res.header("Access-Control-Allow-Methods", "GET");
-  res.header("X-Frame-Options", "DENY");
-  res.header("X-XSS-Protection", "1; mode=block");
-  res.header("X-Content-Type-Options", "nosniff");
-  res.header("Strict-Transport-Security", "max-age=63072000");
-  res.setHeader("Content-Type", "application/json");
+  setDefaultHeaders(res);
 
   if (dutchRandomWord.length > 0) {
     dutchRandomWord = [];
@@ -38,4 +32,4 @@ router.get("/", function (req, res) {
   res.send(JSON.stringify(dutchRandomWord, null, 2));
 });
 
-export default router;
+export default router;

routes/en.js

@@ -4,19 +4,13 @@ import axios from "axios";
 import * as  cheerio from "cheerio";
 import { pronounce } from "node-pronounce";
 import randomUseragent from "random-useragent";
+import { setDefaultHeaders } from "../utils/headers.js";
 const rua = randomUseragent.getRandom();
 var wordOfDay = [];
 const baseUrl = 'https://randomword.com';
 
 router.get("/", function (req, res) {
-  res.header("Access-Control-Allow-Origin", "*");
-  res.header('Access-Control-Allow-Headers', 'Access-Control-Allow-Headers,Content-Type,Access-Control-Allow-Methods, Authorization, X-Requested-With');
-  res.header("Access-Control-Allow-Methods", "GET");
-  res.header("X-Frame-Options", "DENY");
-  res.header("X-XSS-Protection", "1; mode=block");
-  res.header("X-Content-Type-Options", "nosniff");
-  res.header("Strict-Transport-Security", "max-age=63072000");
-  res.setHeader("Content-Type", "application/json");
+  setDefaultHeaders(res);
 
   axios({
     method: "GET",
@@ -70,14 +64,7 @@ router.get("/", function (req, res) {
 });
 
 router.get("/:pos", function (req, res) {
-  res.header("Access-Control-Allow-Origin", "*");
-  res.header('Access-Control-Allow-Headers', 'Access-Control-Allow-Headers,Content-Type,Access-Control-Allow-Methods, Authorization, X-Requested-With');
-  res.header("Access-Control-Allow-Methods", "GET");
-  res.header("X-Frame-Options", "DENY");
-  res.header("X-XSS-Protection", "1; mode=block");
-  res.header("X-Content-Type-Options", "nosniff");
-  res.header("Strict-Transport-Security", "max-age=63072000");
-  res.setHeader("Content-Type", "application/json");
+  setDefaultHeaders(res);
 
   const partOfSpeech = req.params.pos;
 
@@ -132,4 +119,4 @@ router.get("/:pos", function (req, res) {
     });
 });
 
-export default router;
+export default router;

utils/headers.js

@@ -0,0 +1,10 @@
+export const setDefaultHeaders = (response) => {
+  response.header("Access-Control-Allow-Origin", "*");
+  response.header('Access-Control-Allow-Headers', 'Access-Control-Allow-Headers,Content-Type,Access-Control-Allow-Methods, Authorization, X-Requested-With');
+  response.header("Access-Control-Allow-Methods", "GET");
+  response.header("X-Frame-Options", "DENY");
+  response.header("X-XSS-Protection", "1; mode=block");
+  response.header("X-Content-Type-Options", "nosniff");
+  response.header("Strict-Transport-Security", "max-age=63072000");
+  response.setHeader("Content-Type", "application/json");
+}