-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requests onResponse params body not support raw binary data like notepack data #362
Comments
Can you please add a way to reproduce your problem? |
like this. |
Please provide a reproducible example: https://stackoverflow.com/help/minimal-reproducible-example |
this test resp reappeared
works ,,but this make all body become binary..do we need a option to control this |
I'm not sure your test would work because you are sending a body with a GET request - it's not supported in Fastify. |
this test not care about the data of sending ,,the bug happen on response decode,,,you can clone it and have a test,,it realy work,,if you change addBody function in pipelinedRequestsQueue.js and it works good |
i can delete the requestData of |
have you test this problem? |
We do not parse bodies for GETs in fastify. |
i has delete the body, |
I am using autocannon to load test an HTTPS endpoint that accepts (via POST) and returns Content-Type 'application/x-thrift', i.e. an payload encoded using Apache Thrift TBinaryProtocol. I am experiencing the problem described in this issue, which is that PipelinedRequestsQueue.addBody() appends To reproduce save this code as
You can capture the server response using Then save this code as
The client outputs My understanding is that the root cause is that httpClient.js and pipelinedRequestsQueue.js do not handle encoding/charset; or at least I cannot locate any code that does, and the A backwards-compatible solution may be to introduce a |
The order of initialisation in
|
addBody in pipelinedRequestsQueue.js changes it to utf8 string but not notepack decode
The text was updated successfully, but these errors were encountered: