-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cURL parameter compatibility #509
Comments
That's what would need to be changed: Lines 107 to 116 in ac8169c
I would also recommend to modernize this using node core utility for parsing arguments. |
Is it ok for you having a breaking change with the cli ? |
If we can support commands (as aliases) that would be great. If not I'm happy to support the brekage, but I would like to see the impact before confirming. |
I had a parameters review. Some conflicts would be excellent to resolve somehow. Here is a recap below:
Considering the above list, I see two ways to avoid a breaking change: I also started the implementation. If you are interested, I'll also open a PR! Let me know how you prefer to proceed. |
I don't see any major disruption here. I'm ok to ship a major with those changes. |
Hi!
To use autocannon, I commonly follow the steps:
-a 1 -c 1
and see if the status code is 200 (hoping the response body is the same)Unfortunately, the parameter conversion is not easy, and step 3 requires more retries.
My desiderata would be to replace the
cURL
command withautocannon
without parameter conversion.In this way, we can remove some pains during the tests.
Other considerations:
I can take this by providing a PR if you are interested in this enhancement, but please give me some input on where to start.
What do you think?
The text was updated successfully, but these errors were encountered: