-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arg parsing fails if URL ends with ]
#520
Comments
Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests. |
I dig a very small bit of digging into this, and it looks to be a bug in |
Hey @MattIPv4, The author of that module has basically removed their social media presence, including their GitHub, but there’s people who have gotten access to origin control for some of his repos/modules, specifically minimist, a popular cli parsing library that subarg was built to be used with. I’ve reached out here, and got a reply they’ll try get access to that repo - https://twitter.com/ljharb/status/1780589808382800279 This’ll allow us to upstream that fix without needing to create a successor fork. |
👀 That tweet link doesn't go anywhere, but sounds good. And to confirm, you meant getting access to subarg, not minimist? |
My bad, deleted a few chars at the end! 😅 Its fixed now, fyi. And yes, we're looking for subarg access to fix there. |
Give me a few days to a week (or two), and I’ll either have the original package name and repo, or I’ll make a fork. |
Unfortunately Github/npm weren't wiling or able to help, so I'll have to recover the repo myself and make a fork. I'll comment here once that's done. |
Thanks |
https://github.com/minimistjs/subarg is now recovered, and i published the 3 original versions as I did not make any changes on these 3 publishes besides the package name, so the repo URL will still be incorrect. I intend to publish a v1.0.1 after updating CI and other things, which will have the correct URLs, but in the meantime, you can do a drop-in replacement of |
#524 replaces the dep; i'd love a detailed issue and/or PR in subarg about the underlying problem for this issue :-) |
I plan on picking this up btw if @MattIPv4 doesnt get a chance. I’m on vacation atm so sorry for the late response. |
Go for it, I've been super busy w/ work et al. Sorry! |
Just back from vacation, will self assign this. |
autocannon http://localhost\?id=\[1\]
results in the help message being shown (if you logargv
, it seems that the URL [missing the closing]
] is buried inargv._[0]._[0]
).autocannon http://localhost\?id=\[1\]\&other
works as expected though (and loggingargv
shows that the URL is atargv._[0]
as the code expects.The text was updated successfully, but these errors were encountered: