Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper copy semantics for C++ BandInfo #159

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Proper copy semantics for C++ BandInfo #159

merged 2 commits into from
Jan 28, 2020

Conversation

JonathanMeans
Copy link
Contributor

Fixes #158

@christianwhite1193
Copy link
Contributor

Looks good.

@christianwhite1193 christianwhite1193 merged commit f2ee167 into master Jan 28, 2020
JonathanMeans added a commit that referenced this pull request Jan 29, 2020
@JonathanMeans
Revert "Merge pull request #159 from mdaus/band_info_copy"
ba2d1b6 
This reverts commit f2ee167, reversing
changes made to 3f51d12.

Copy constructor leads to segfaults.
JonathanMeans added a commit that referenced this pull request Jan 29, 2020
@JonathanMeans
Merge pull request #160 from mdaus/revert_copy_constructor
3bce1fb 
Revert "Merge pull request #159 from mdaus/band_info_copy"
@JDanielSmith JDanielSmith deleted the band_info_copy branch September 9, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianwhite1193 christianwhite1193 Awaiting requested review from christianwhite1193

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RGB band representation written as all Blue (B) for RGB band in Image Sub Header
2 participants
@JonathanMeans @christianwhite1193