Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Enable NumberFormat v3 #27746

Closed
9 of 10 tasks
Tracked by #422
bsmth opened this issue Jul 4, 2023 · 2 comments
Closed
9 of 10 tasks
Tracked by #422

[JS] Enable NumberFormat v3 #27746

bsmth opened this issue Jul 4, 2023 · 2 comments
Assignees
Labels
Content:JS JavaScript docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@bsmth
Copy link
Member

bsmth commented Jul 4, 2023

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

Related Gecko bugs

Other

  • Check content open issues to see if any pertain to the subject matter. If there are any that can be closed because of the work, do so. If there are any that can be fixed relatively quickly because of the knowledge from completing this issue and you have time, feel free to go ahead and fix them.
  • Check if glossary updates are required for the feature you're documenting - whether an existing term needs to be updated or a new term should be added.
  • Check if BCD update means that content pages need to have experimental markup removed or deprecated markup added (front matter tags and macros).
@bsmth bsmth added Content:JS JavaScript docs Firefox 116 labels Jul 4, 2023
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 4, 2023
@bsmth bsmth removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 4, 2023
@Elchi3
Copy link
Member

Elchi3 commented Jul 4, 2023

Would be great to get a review on mdn/browser-compat-data#20262

@hamishwillee hamishwillee self-assigned this Jul 17, 2023
@hamishwillee
Copy link
Collaborator

hamishwillee commented Jul 17, 2023

I'm still checking the status of this. But minimally

  • Add exceptions sections
  • PluralRules constructor
    • These probably : [[MinimumIntegerDigits]], [[MinimumFractionDigits]], [[MaximumFractionDigits]], [[MinimumSignificantDigits]], [[MaximumSignificantDigits]], [[RoundingType]],
    • These in the new proposal and no docs, maybe no BCD [[RoundingMode]], [[RoundingIncrement]], [[TrailingZeroDisplay]]
    • PluralRules.resolvedOptions() this takes some of the new options. Might have a BCD option.
    • PluralRules.selectRange() - new and documented. But need to sanity check. Perhaps with live example or interactive example:
  console.log("Available: resolvedOptions().useGrouping === 'auto'");
}
else {
   console.log("Not available: resolvedOptions().useGrouping === 'auto'"); 
}

Status:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
Archived in project
Development

No branches or pull requests

4 participants