Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relnote(116): SVG q unit supported (defined in CSS length units) #27950

Merged
merged 6 commits into from
Jul 24, 2023
Merged

relnote(116): SVG q unit supported (defined in CSS length units) #27950

merged 6 commits into from
Jul 24, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jul 14, 2023 •
edited
Loading

Adding a release note for SVG q length unit:

<svg style="height: 150q; width: 150q; background: red;" x="0" y="0"></svg>
let mySvg = document.createElementNS("http://www.w3.org/2000/svg", "svg");
mySvg.setAttribute("style", "height: 100q; width: 100q; background: red;");
mySvg.setAttribute("x", "0");
mySvg.setAttribute("y", "0");

document.body.appendChild(mySvg);

other changes:

  • Added references to CSS specs for definitions of common length units.
  • Minor cleanup for \<type> reverting

TODO:

  • revert formatting of SVG types

Related issues and pull requests:

Bugzilla:

@bsmth bsmth requested a review from a team July 14, 2023 13:11
@bsmth bsmth requested a review from a team as a code owner July 14, 2023 13:11
@bsmth bsmth requested review from Ryuno-Ki and hamishwillee and removed request for a team July 14, 2023 13:11
@github-actions github-actions bot added Content:SVG SVG docs Content:Firefox Content in the Mozilla/Firefox subtree labels Jul 14, 2023
@bsmth bsmth mentioned this pull request Jul 14, 2023
Closed
11 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023 •
edited
Loading

Preview URLs

Flaws (2)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/SVG/Content_type
Title: Content type
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/SVGColor does not exist
    • /en-US/docs/Web/API/SVGPaint does not exist
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/116
Title: Firefox 116 for developers

(comment last updated: 2023-07-24 08:49:48)

@bsmth bsmth requested a review from hamishwillee July 18, 2023 15:24
hamishwillee
hamishwillee approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks.

@hamishwillee hamishwillee merged commit d5e9826 into mdn:main Jul 24, 2023
6 checks passed
@bsmth
Copy link
Member Author

bsmth commented Jul 25, 2023

Thanks, Hamish 👍🏻

@bsmth bsmth deleted the 27759-svg-q-unit branch July 25, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@hamishwillee hamishwillee hamishwillee approved these changes

@Ryuno-Ki Ryuno-Ki Awaiting requested review from Ryuno-Ki

Assignees
No one assigned
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:SVG SVG docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsmth @hamishwillee @Josh-Cena