-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete deprecated clip example #35956
Conversation
Preview URLs (comment last updated: 2024-10-23 18:54:56) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes this input actually visible because it has 1px size. Have you checked out the suggestion in #35743 (comment)?
adding modern `clip-path: inset(50%);` property
files/en-us/web/api/file_api/using_files_from_web_applications/index.md
Outdated
Show resolved
Hide resolved
…/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I guess I was over ambitious by taking up this task 😞 . I hope I understood the context better this time. I am still not very confident with CSS styling. |
I'm not confident with reviewing this either
Perhaps @estelle could say more about best practices here. |
So I tested both stylings, the one in the MDN docs and other from the A11Y project. They both seem to have the same output but both of them use So next, I went to the clip doc on MDN to see any suggestions are made on how to replace clip. This suggested to use the new So I then tested the code removing So I went and changed the CSS styling by completely removing However, doing all these tests got me curious as to why there is a need to use any Here are the screenshots. With with new clip-path Without both Please let me know if I am missing anything in my understanding. I am still not great with CSS and all its complexities 🙈 . |
add clip-path remove clip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Also, congratulations on your first merged MDN content PR. Welcome to the team!
Description
clip
is deprecated; deleted it from the CSS example in this page https://developer.mozilla.org/en-US/docs/Web/API/File_API/Using_files_from_web_applicationsfixes #35743
Motivation
I have learnt so much from MDN docs and want to contribute back. Deleting deprecated examples with help reader learn relevant stuff.