fix(layout): avoid sidebar overflow beyond footer #11621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
C17AN
changed the title
This was referenced Aug 16, 2024
caugner
changed the title
caugner
changed the title
caugner
approved these changes
Sep 6, 2024
|
Thank you @C17AN for your investigation and the light-weight fix! 🙌 |
|
I'm glad it helped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11609.
Problem
If the sidebar contains many elements, an unnecessary scroll area would be added on devices with a width between 768px and 1200px.
Solution
The same issue did not occur on desktop, so I first identified which element's style was different. After confirming that the issue was occurring with the
.sidebarelement, I applied position: sticky as it was on the desktop.Screenshots
Before
After
How did you test this change?