Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the sidenav-inner full height when there is no adds to display for paying users #11645

Closed
LcsGa opened this issue Aug 18, 2024 · 0 comments · Fixed by #11787
Closed

Make the sidenav-inner full height when there is no adds to display for paying users #11645

LcsGa opened this issue Aug 18, 2024 · 0 comments · Fixed by #11787
Labels
effort: small This task is a small effort. has PR Issues that already have a PR layout Issues related to alignment, positioning and spacing/margin/padding p2 We want to address this but may have other higher priority items. placement

Comments

@LcsGa
Copy link

LcsGa commented Aug 18, 2024

On mobile phone (and maybe other devices), as a paying user, I removed the adds from the sidebar, but then I realized that the space meant for it is empty and the menu could take the full height of it.
image
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Aug 18, 2024
LcsGa added a commit to LcsGa/yari that referenced this issue Aug 18, 2024
@LcsGa
[mdn#11645] feat(sidebar-inner): enlarge the sidebar-inner element by…
68a88c7 
… removing the section when it is empty
@LcsGa LcsGa mentioned this issue Aug 18, 2024
Closed
LcsGa added a commit to LcsGa/yari that referenced this issue Aug 18, 2024
@LcsGa
[mdn#11645] feat(sidebar-inner): enlarge the sidebar-inner element by…
7952de8 
… removing the section when it is empty
@caugner caugner added layout Issues related to alignment, positioning and spacing/margin/padding placement labels Sep 3, 2024
@caugner caugner added p2 We want to address this but may have other higher priority items. has PR Issues that already have a PR effort: small This task is a small effort. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Sep 10, 2024
@caugner caugner mentioned this issue Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: small This task is a small effort. has PR Issues that already have a PR layout Issues related to alignment, positioning and spacing/margin/padding p2 We want to address this but may have other higher priority items. placement
Projects
None yet
Milestone
No milestone
2 participants
@caugner @LcsGa