Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setRotationRate for local blocks does not work correctly #353

Open
lamkina opened this issue May 14, 2024 · 0 comments
Open

setRotationRate for local blocks does not work correctly #353

lamkina opened this issue May 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@lamkina
Copy link
Contributor

lamkina commented May 14, 2024

Description

The setRoationRate function in pyADflow has a bug that prevents assigning specific rotation rates to individual blocks. Instead, the rate is applied to n cgns blocks starting form the first block number.

PR #323 potentially has fixes for this bug, however due to inactivity and incompleteness that PR has been closed.

Steps to reproduce issue

PR #323 identified this bug, but no tests or MWE was provided.

Current behavior

Currently ADflow applies the rotation rate the first n blocks instead of targeting specific blocks provided by the user.

Expected behavior

Rotation rates should be applied to specific blocks provided by the user.

@lamkina lamkina added the bug Something isn't working label May 14, 2024
@lamkina lamkina changed the title Rotation rate for local blocks does not work correctly setRotationRate for local blocks does not work correctly May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant