Skip to content

Commit

Permalink
Fix build failure (#69)
Browse files Browse the repository at this point in the history
* Bump oldest tested numpy version from 1.20 to 1.21

* Add numpy upper bound of <2 since OpenMDAO doesn't support it yet

* Updated latest numpy version in the docs
  • Loading branch information
eytanadler authored Jul 12, 2024
1 parent 7ab3c6a commit 1032ad4
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/openconcept.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
PYTHON_VERSION_LATEST: ['3.11']
PIP_VERSION_OLDEST: ['23.0.1'] # pip>=23.1 cannot build the oldest OpenMDAO
SETUPTOOLS_VERSION_OLDEST: ['66.0.0'] # setuptools >= 67.0.0 can't build the oldest OpenMDAO
NUMPY_VERSION_OLDEST: ['1.20'] # latest is most recent on PyPI
NUMPY_VERSION_OLDEST: ['1.21'] # latest is most recent on PyPI
SCIPY_VERSION_OLDEST: ['1.7.0'] # latest is most recent on PyPI
OPENMDAO_VERSION_OLDEST: ['3.21'] # latest is most recent on PyPI
fail-fast: false
Expand Down
2 changes: 1 addition & 1 deletion doc/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ OpenConcept is tested regularly on builds with the oldest and latest supported p
- 3.30
* - NumPy
- 1.20
- latest
- 1.26
* - SciPy
- 1.7.0
- latest
Expand Down
2 changes: 1 addition & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ OpenConcept is tested regularly on builds with the oldest and latest supported p
| ------- | ------- | ------ |
| Python | 3.8 | 3.11 |
| OpenMDAO | 3.21 | 3.30 |
| NumPy | 1.20 | latest |
| NumPy | 1.20 | 1.26 |
| SciPy | 1.7.0 | latest |
| OpenAeroStruct | latest | latest |

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
install_requires=[
# Update the oldest package versions in the GitHub Actions build file, the readme,
# and the index.rst file in the docs when you change these
"numpy>=1.20",
"numpy >=1.20, <=1.26", # OpenMDAO is not compatible with NumPy v2
"scipy>=1.7.0",
"openmdao >=3.21, <=3.30",
],
Expand Down

0 comments on commit 1032ad4

Please sign in to comment.