Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an example of the non-intuitive child ffd behavior #28

Closed
wants to merge 2 commits into from
Closed

Added an example of the non-intuitive child ffd behavior #28

wants to merge 2 commits into from

Conversation

joanibal
Copy link
Collaborator

added a test script to the examples folder to highlight this case

@joanibal joanibal requested a review from nbons February 21, 2020 17:15
@joanibal joanibal linked an issue Feb 21, 2020 that may be closed by this pull request
Child FFD deltas not calculated with the same point set as parent. #7
Open
nbons
nbons reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@nbons nbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really cool if you had some matplotlib code to plot the FFDs and the deformed points. But that's kind of extra credit.

examples/childffd_warning/warning_childFFD.py Show resolved Hide resolved
@ewu63
Copy link
Collaborator

ewu63 commented Mar 20, 2020

@joanibal did you have a chance to look at Nick's comments?

@joanibal
Copy link
Collaborator Author

Yes, and I've been putting it off.

@joanibal joanibal changed the base branch from pyGeo to master April 17, 2020 15:09
@eirikurj
Copy link
Contributor

eirikurj commented Jun 2, 2020

@joanibal did you have any chance to address Nicks comments.
Does it make sense to try to integrate this into our testing?

@joanibal
Copy link
Collaborator Author

joanibal commented Jun 3, 2020

The changes to BaseRegTest broke this and the other "new" tests for pygeo.
So, I'm going to wait until BeseRegTest stabilizes before I fix this PR.

@ewu63
Copy link
Collaborator

ewu63 commented Oct 16, 2020

@joanibal the BaseRegTest stuff is pretty stable now I think

@ewu63 ewu63 mentioned this pull request Dec 3, 2020
Closed
@joanibal
Copy link
Collaborator Author

moved to #55

@joanibal joanibal closed this Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbons nbons nbons left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Child FFD deltas not calculated with the same point set as parent.
4 participants
@joanibal @ewu63 @eirikurj @nbons