Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing framework #145

Closed
ewu63 opened this issue Jul 26, 2020 · 4 comments · Fixed by #251
Closed

Update testing framework #145

ewu63 opened this issue Jul 26, 2020 · 4 comments · Fixed by #251
Labels
enhancement New feature or request stale *crickets chirp*

Comments

@ewu63
Copy link
Collaborator

ewu63 commented Jul 26, 2020

Type of issue

What types of issue is it?
Select the appropriate type(s) that describe this issue

  • Testing

Description

We should update the overall testing framework:

  • evaluate if we want to add other optimization problems
  • share code among tests -- most of them are doing similar things and we should reduce code duplication
  • improve overall code coverage
@matbesancon matbesancon mentioned this issue Sep 10, 2020
Closed
60 tasks
@ewu63
Copy link
Collaborator Author

ewu63 commented Sep 10, 2020

Hi Mathieu, would you mind opening a new issue for this so that we may discuss there? This issue is more about the overall scope of testing, and refactoring some existing tests.

@matbesancon
Copy link

Deleted comment that was my mistake

@marcomangano marcomangano mentioned this issue Sep 12, 2020
Merged
4 tasks
@ewu63 ewu63 added the enhancement New feature or request label Sep 17, 2020
@stale
Copy link

stale bot commented Mar 20, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale *crickets chirp* label Mar 20, 2021
@ewu63 ewu63 linked a pull request May 13, 2021 that will close this issue
Refactor tests #251
Merged
8 tasks
@ewu63
Copy link
Collaborator Author

ewu63 commented May 13, 2021

Closed partially by #251, and superseded by #256.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request stale *crickets chirp*
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor tests mdolab/pyoptsparse
2 participants
@ewu63 @matbesancon