Updating minimum dependency requirements #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 74.10% 74.10%
=======================================
Files 22 22
Lines 3290 3290
=======================================
Hits 2438 2438
Misses 852 852 ☔ View full report in Codecov by Sentry. |
sseraj
previously approved these changes
Feb 28, 2024
|
@marcomangano just to formally respond and for future reference. I am in favor of SPEC 0 for our codebase. We have been discussing this in https://github.com/mdolab/docker/issues/241 and should continue there. |
|
Bumped the minor version since the minimum version update could potentially be a breaking change? |
13 tasks
13 tasks
eirikurj
approved these changes
Apr 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Issues like #387 show that the current minimum dependency versions are out of date - even considering our own stencil of supported dependencies.
I updated the minimum numpy and scipy versions to our
stableset of dependencies.However, I think we should also update the
mdolab-baseclassesversion and, more importantly, the minimum python version. The code itself is not changing but this would create issues for the users who are still relying on older python environments.@ewu63 suggests to adopt the NEP29 (or the more recent SPEC 0 policy) to avoid this issue, but I think at that point we should extend this to the whole organization packages.
I want to hear @eirikurj take as well as he has been working on a way to map these dependencies over time.
Expected time until merged
1 day if we are ok with only updating numpy and scipy
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable