Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializing a pyVolume object by fitting to the baseline data does not work. #49

Open
anilyil opened this issue Sep 24, 2022 · 0 comments

Comments

@anilyil
Copy link
Contributor

anilyil commented Sep 24, 2022

Description

The least squares fit based initialization of volumes don't work, OR the test that was using this initialization was broken. The original data that looks like this:
actual_data
results in a pyVolume object that looks like this:
failed_fit
Either the functionality is broken, or the test was written incorrectly. Either way, I removed this approach in #47 and opened this issue. This should be tested to make sure the initialization fit works as intended. Then we need to add this back to the tests. For now, I am creating the test volume by directly providing control points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant