Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async support and format with black #62

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

anna-hope
Copy link
Contributor

@anna-hope anna-hope commented Mar 17, 2022

  • Closes [Feature request] 'firestore.AsyncClient' support #55 by adding:
    • AsyncClient
    • AsyncDocumentReference
    • AsyncCollectionReference
    • AsyncQuery
    • AsyncTransaction
  • Removes deprecation warnings from Collection.get and other equivalent methods, since they are apparently no longer deprecated in the official Firestore client
  • Refactors several methods in sync classes to allow for better code reuse with their async counterparts
  • Fixes formatting in several places by using black (closes Use black formatting #63) (I can undo this if @mdowds would really prefer not to use Black)
  • Adds async examples to the README
  • Updates my name and GitHub profile link in the list of contributors

@anna-hope anna-hope changed the title Add async support Add async support and format with black Mar 17, 2022
benvdh-incentro and others added 4 commits June 2, 2022 14:40
* Fix error: 'async_generator' object is not iterable

* Replace async list comprehension with existing consume_async_iterable

* Remove unused import
@benvdh-incentro
Copy link

@mdowds Can this be reviewed, merged, and released to PyPI? It would be great to have Async support in python-mock-firestore...

I have tested Anna's code, and after I fixed a small bug it worked great!

@kamikaz1k
Copy link

@mdowds wondering if this package is still maintained, and/or if you have an alternative to suggest. The SEO for this package is quite good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use black formatting [Feature request] 'firestore.AsyncClient' support
3 participants