[BUG] Default value issue after server crash

[bblaha]

Problem description

My server went down due to a short power outage. Once it was back up it threw a lot of errors, mostly in the direction of some field not having default values. Example:

Field 'Fleet_Array_Changes' doesn't have a default value

INSERT INTO _fleet_archive
(`Fleet_ID`, `Fleet_Owner`, `Fleet_Mission`, `Fleet_Array`, `Fleet_Time_Send`, `Fleet_Time_Start`, `Fleet_Time_Stay`, `Fleet_Time_End`, `Fleet_Start_ID`, `Fleet_Start_Galaxy`, `Fleet_Start_System`, `Fleet_Start_Planet`, `Fleet_Start_Type`, `Fleet_Start_Res_Metal`, `Fleet_Start_Res_Crystal`, `Fleet_Start_Res_Deuterium`, `Fleet_End_ID`, `Fleet_End_ID_Galaxy`, `Fleet_End_Galaxy`, `Fleet_End_System`, `Fleet_End_Planet`, `Fleet_End_Type`, `Fleet_End_Owner`, `Fleet_ACSID`, `Fleet_Info_HadSameIP_Ever`, `Fleet_Info_HadSameIP_Ever_Filtred`, `Fleet_Info_HadSameIP_OnSend`, `Fleet_Info_UsedTeleport`)
VALUES 
(525, 2, 4, '210,1', 1588597094, 1588597203, 0, 1588597312, 2, 1, 429, 7, 1, 0, 0, 0, '6', '6', 1, 322, 14, 1, '2', '0', false, false, false, 0) 

File: /fleet3.php
User: XXX[2]

The problem first appeared only on the overview.php site, by now it appears on every single site.

What I have tried:
Giving the fields causing the error (Fleet_Array_Changes, building_queue and some more) a default value of NULL. This solves the problem above, however after fleet_archive starts getting filled with NULL default entries for every fleet action I get an error because every insert into query is filled with "!noupt!", which is supposed to be this way according to FlyingFleetHandler.php
if($DataVal === null) { $DataVal = '"!noupd!"'; }
The error disappears when I delete all fleets from the database but occurs again, when fleets either Turn Back or arrive at their destination. After a while all pages show the error listed in the first place.

I can only imagine that the crash caused a query to be cancelled mid-execution, but I was not able to find a fix for it.

Engine details

• Engine version:
  • version 1.0.0
• Custom modifications:
  • Yes
  • No
• Environment:
  • local
  • testing (inaccessible from the outside)
  • production (accessible from the outside world)
• Configuration:
  • Game speeds
  • Debris settings
  • Any other relevant config entry

Steps to reproduce

Cannot reproduce, but cannot fix

Expected behavior

Fleets get sent correctly, building queues are handled correctly

Actual behavior

Error occurs on every page loaded

[mdziekon]

I don't know how power outage could have affected your MySQL instance (that's a problem beyond this project's scope), but the SQL error you've pasted looks like the one mentioned in another issue: #41

If messing around with STRICT_TRANS_TABLES does not yield any results, and you didn't have this problem before, restoring from a backup sounds like the only solution.

[mdziekon]

I also do not recommend adding any default values. As you've already noticed, it might break how the engine works. Unfortunatelly, there are some places where batch updates are packed in just a single query with a hackish method to do that. So, until I rewrite these batch updates to normal transactions, we're all stuck with these limitations mentioned in README.

[bblaha]

I'm impressed, indeed for whatever reason the power outage re-activated STRICT_TRANS_TABLES.
I did not even think of that. De-activated it manually and now it works perfectly.
Thanks for your help!