-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor messaging system to allow more flexibility #126
Labels
enhancement_request
All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Comments
mdziekon
added a commit
that referenced
this issue
Aug 1, 2020
mdziekon
added a commit
that referenced
this issue
Aug 1, 2020
mdziekon
added a commit
that referenced
this issue
Aug 1, 2020
mdziekon
added a commit
that referenced
this issue
Aug 1, 2020
mdziekon
added a commit
that referenced
this issue
Aug 1, 2020
mdziekon
added a commit
that referenced
this issue
Aug 2, 2020
mdziekon
added a commit
that referenced
this issue
Aug 2, 2020
mdziekon
added a commit
that referenced
this issue
Aug 3, 2020
mdziekon
added a commit
that referenced
this issue
Aug 20, 2020
3 tasks
mdziekon
added a commit
that referenced
this issue
Aug 20, 2020
mdziekon
added a commit
that referenced
this issue
Sep 12, 2020
mdziekon
added a commit
that referenced
this issue
Sep 13, 2020
mdziekon
added a commit
that referenced
this issue
Sep 13, 2020
mdziekon
added a commit
that referenced
this issue
Sep 23, 2020
mdziekon
added a commit
that referenced
this issue
Sep 23, 2020
mdziekon
added a commit
that referenced
this issue
Sep 23, 2020
mdziekon
added a commit
that referenced
this issue
Sep 23, 2020
mdziekon
added a commit
that referenced
this issue
Sep 23, 2020
mdziekon
added a commit
that referenced
this issue
Oct 25, 2020
mdziekon
added a commit
that referenced
this issue
Oct 25, 2020
mdziekon
added a commit
that referenced
this issue
Oct 25, 2020
mdziekon
added a commit
that referenced
this issue
Oct 25, 2020
mdziekon
added a commit
that referenced
this issue
Oct 26, 2020
mdziekon
added a commit
that referenced
this issue
Oct 26, 2020
mdziekon
added a commit
that referenced
this issue
Oct 26, 2020
mdziekon
added a commit
that referenced
this issue
Oct 26, 2020
mdziekon
added a commit
that referenced
this issue
Oct 26, 2020
mdziekon
added a commit
that referenced
this issue
Oct 26, 2020
mdziekon
added a commit
that referenced
this issue
Oct 27, 2020
mdziekon
added a commit
that referenced
this issue
Oct 27, 2020
mdziekon
added a commit
that referenced
this issue
Oct 27, 2020
mdziekon
added a commit
that referenced
this issue
Oct 27, 2020
…, as unread (prevents leaking the information that the recipient has not read the message)
mdziekon
added a commit
that referenced
this issue
Oct 27, 2020
mdziekon
added a commit
that referenced
this issue
Oct 27, 2020
mdziekon
added a commit
that referenced
this issue
Oct 27, 2020
…-part3 Refactor messages displaying code
mdziekon
added a commit
that referenced
this issue
Nov 9, 2020
mdziekon
added a commit
that referenced
this issue
Nov 9, 2020
mdziekon
added a commit
that referenced
this issue
Nov 9, 2020
mdziekon
added a commit
that referenced
this issue
Nov 9, 2020
mdziekon
added a commit
that referenced
this issue
Nov 9, 2020
mdziekon
added a commit
that referenced
this issue
Nov 10, 2020
mdziekon
added a commit
that referenced
this issue
Nov 10, 2020
mdziekon
added a commit
that referenced
this issue
Nov 10, 2020
mdziekon
added a commit
that referenced
this issue
Nov 10, 2020
mdziekon
added a commit
that referenced
this issue
Nov 10, 2020
2 tasks
mdziekon
added a commit
that referenced
this issue
Nov 11, 2020
…-part4 Refactor message categories displaying code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement_request
All issues containing enhancements proposals to the existing functionalities, codebase or dev setup
Summary
Current messaging system is inflexible in terms of how the message arguments can be presented and transformed before presentation to the user. In certain cases, it leads to bugs like #99, where certain piece of the message is "hardcoded" in the sender's message.
The messaging system should be refactored so that every "system message" could be programmatically transformed before being displayed, based on "facts-only" arguments stored as message's arguments. For example, instead of persisting the label of "origin point type" (
Planet / Moon
), we should be able to store the type's identifier, and then, when the message is about to be displayed, transform that into appropriate label. Not only this will make this more flexible and resitant to bugs, but also may result in a bit of space saving (however, that might be negated by the persistence format, which will most likely change to just JSON; still, space savings are not a priority anymore, at least not that low-level savings).Related issues or PRs:
The text was updated successfully, but these errors were encountered: