Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on Angular 10 #656

Open
2 of 6 tasks
vanderdill opened this issue Jul 1, 2020 · 10 comments
Open
2 of 6 tasks

Doesn't work on Angular 10 #656

vanderdill opened this issue Jul 1, 2020 · 10 comments

Comments

@vanderdill
Copy link

What type of issue are you creating?

  • Bug
  • Enhancement
  • Question

What version of this module are you using?

  • 2.0.10 (Stable)
  • 2.1.0-rc.n (2.1 Release Candidate n)
  • Other

Please add a description for your issue:

Angular 10 now requires template on ModuleWithProviders class. So, the following line on index.ts:
}): ModuleWithProviders {

showld be:
}): ModuleWithProviders<SDKBrowserModule> {

@Schinkentanz
Copy link

Schinkentanz commented Jul 24, 2020

I've added a fix & opened a pull req: #657

@vanderdill
Copy link
Author

vanderdill commented Jul 24, 2020

I've added a fix & opened a pull req: #657

Unfortunately the author(s) doesn't seem to keep mantaining the project. There are pull request opened from 2018 :/.
I've made my own fork to fix this.

@Schinkentanz
Copy link

Dito ;) but at least i tried

@psomby
Copy link

psomby commented Aug 6, 2020

Same here, would be nice that it gets fixed but I guess that won't happen..

@rollwhistler
Copy link

rollwhistler commented Mar 22, 2021

I've added a fix & opened a pull req: #657

Unfortunately the author(s) doesn't seem to keep mantaining the project. There are pull request opened from 2018 :/.
I've made my own fork to fix this.

Can you share that by any chance? :-) @vanderdill

@Schinkentanz
Copy link

@rollwhistler You can install dependencies by defining them by their github.com path.
That way you could use my fork or fork it yourself 🙂 👍

{
  "devDependencies": {
    "@mean-expert/loopback-sdk-builder": "Schinkentanz/loopback-sdk-builder#0e05fb6"
  }
}

@rollwhistler
Copy link

rollwhistler commented Mar 22, 2021

Thanks @Schinkentanz, I cannot just fork it myself since I would need to implement the fixes, which I don't know how to right now :-), I was hoping for a working updated version of this.

Does yours work with Angular 10? I'll give it a try, thank you!

@Schinkentanz
Copy link

😄
Yes, I used this fix with v10 and currently with v11.2.2 👍

@rollwhistler
Copy link

rollwhistler commented Mar 26, 2021

src/app/shared/sdk/services/custom/logger.service.ts:51:13 - error TS2339: Property 'profileEnd' does not exist on type 'Console'.

Will this go away if I update to angular 11? :-D.

Ok, it was my fault, I got old type definitons on my package.json, I updated to "@types/node": "^10.17.55"
and now is fine.

@jbratu
Copy link

jbratu commented Jun 15, 2021

Look at Loopback 4 documentation Building an Angular Application from OpenAPI Specification which shows how to generate an OpenAPI spec JSON file and then generate models for the Angular application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants