Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint: Not all instances of declaration-no-important are tripping the linter #51

Open
Tregonia opened this issue Feb 6, 2020 · 0 comments
Assignees

Comments

@Tregonia
Copy link
Contributor

Tregonia commented Feb 6, 2020

Found that there are instances of !important in the base theme styles that are not tripping the linter.

https://github.com/mediacurrent/theme_generator_8/blob/master/generators/app/templates/_src/patterns/global/utils/_mixins.scss#L15

The linter issues can be resolved with the following ignore comment, but the reason for these items not tripping the linter needs to be isolated.
/* stylelint-disable-next-line declaration-no-important */

The clearfix mixin is also is not tripping the rule-empty-line-before rule.

All instances are found within mixins.

@Tregonia Tregonia self-assigned this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant