-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#1670): rename and reorganize the design system section #1701
base: main
Are you sure you want to change the base?
Conversation
Hey @Ziithe and @n-orlowski , I have a couple of questions and items to be addressed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a comment with items to be addressed.
I believe @ZiitheH mentioned she synced with you but there are a few things I wanted to clarify:
|
Thanks for the clarification @n-orlowski , I think we should keep the |
Gotcha! Resources should already be integrated into the content in this branch and empathy mapping is replaced by our updated methodologies (so we should remove this) @ZiitheH can you please update to reflect this document's architecture? (changes are adding the Mockup page under UI and Mapping Hierarchy as it's own section) |
Dismissing my review as I will finalize the work Ziithe started.
@mrjones-plip this PR is ready for review. 🎆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow - A lot of work went to this with many contributors - impressive!!
Before jumping in can you please update the PR body and the two upstream tickets here and here?
Since I have no background on what we're trying to achieve, I can't tell what this intends to solve, for example:
Create Designing branch with new info arch - So that n-orlowski can populate content 🙏
@mrjones-plip I added details to the PR about I understood that this PR does. Please let me know if you need more details. |
Ah - great! It's a night and day difference after you added an image or two and a couple sentences - it's so much more clear what we're doing. Thanks @andrablaj ! Given these large moves can be tricky and inadvertently cause As well, having this documented and in CI will be a great win for new contributors to the docs, including those outside of medic. |
@mrjones-plip I agree with the need for a link checker script to be part of CI. Let's keep this in review until we complete that part. I will let you know if I get to have a look at that script before you do. |
Description
Complete revamp of the
Design System
section. It includes a reorganisation of the existing pages, as well as splitting of pages into more concise ones. To simplify the navigation, it merges all the guides, icons and existing components underInterface
.Additionally. it adds a new section about
User Experience Research
.Current navigation:
Proposed navigation:
Closes #1670
Closes #1650
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.