Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oauth2 Client Credentials Flow #457

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add oauth2 Client Credentials Flow #457

wants to merge 1 commit into from

Conversation

knoppiks
Copy link
Collaborator

@knoppiks knoppiks commented Dec 9, 2024

No description provided.

@knoppiks knoppiks self-assigned this Dec 9, 2024
@knoppiks knoppiks linked an issue Dec 9, 2024 that may be closed by this pull request
Add OpenID Connect Client Credentials Flow #224
Open
@knoppiks knoppiks force-pushed the 224-add-openid-connect-client-credentials-flow branch from d098051 to d0ed984 Compare December 9, 2024 13:21
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 9, 2024
View reviewed changes
clinical-domain-agent/src/main/java/care/smith/fts/cda/impl/TCACohortSelectorFactory.java Outdated
this.meterRegistry = meterRegistry;
log.info("Factory client {}", clientBuilder);
this.clientBuilder = requireNonNull(clientBuilder);
log.info("Factory client {}", clientFactory);

Check notice

Code scanning / CodeQL

Use of default toString()

Default toString(): WebClientFactory inherits toString() from Object, and so is not suitable for printing.
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 75.26882% with 23 lines in your changes missing coverage. Please review.

Project coverage is 94.73%. Comparing base (1128ee2) to head (d0ed984).

Files with missing lines Patch % Lines
...care/smith/fts/util/auth/HttpClientOAuth2Auth.java 0.00% 11 Missing ⚠️
...care/smith/fts/util/auth/HttpServerOAuth2Auth.java 0.00% 7 Missing ⚠️
...n/java/care/smith/fts/util/AgentConfiguration.java 50.00% 4 Missing ⚠️
...ain/java/care/smith/fts/util/WebClientContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #457      +/-   ##
============================================
- Coverage     96.01%   94.73%   -1.29%     
+ Complexity      420      411       -9     
============================================
  Files           107      111       +4     
  Lines          1531     1556      +25     
  Branches         39       39              
============================================
+ Hits           1470     1474       +4     
- Misses           44       65      +21     
  Partials         17       17
Files with missing lines Coverage Δ
...n/java/care/smith/fts/cda/ClinicalDomainAgent.java 75.00% <ø> (-6.82%) ⬇️
...re/smith/fts/cda/impl/DeidentifhirStepFactory.java 100.00% <100.00%> (ø)
...th/fts/cda/impl/EverythingDataSelectorFactory.java 100.00% <100.00%> (ø)
...are/smith/fts/cda/impl/RDABundleSenderFactory.java 100.00% <100.00%> (ø)
...e/smith/fts/cda/impl/TCACohortSelectorFactory.java 100.00% <100.00%> (ø)
.../smith/fts/cda/rest/TransferProcessController.java 95.12% <100.00%> (ø)
...n/java/care/smith/fts/rda/ResearchDomainAgent.java 75.00% <ø> (-6.82%) ⬇️
...re/smith/fts/rda/impl/DeidentifhirStepFactory.java 100.00% <100.00%> (ø)
...ith/fts/rda/impl/FhirStoreBundleSenderFactory.java 100.00% <100.00%> (ø)
...main/java/care/smith/fts/tca/TrustCenterAgent.java 50.00% <ø> (-21.43%) ⬇️
... and 15 more

@knoppiks knoppiks force-pushed the 224-add-openid-connect-client-credentials-flow branch from d0ed984 to 17e4c9c Compare December 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@knoppiks knoppiks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OpenID Connect Client Credentials Flow
1 participant
@knoppiks